Skip to content

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Sep 26, 2024

Add deletion_protection = false for google_cloud_run_v2_service for TPGv6

In partial resolution of #740

@apeabody apeabody requested review from a team as code owners September 26, 2024 23:07
@apeabody apeabody changed the title fix(run): add deletion_protection fix(cloud_run): add deletion_protection Sep 26, 2024
@apeabody apeabody requested a review from glasnt September 26, 2024 23:56
@apeabody
Copy link
Contributor Author

@glasnt - Looks like there are a few other issues (e.g. google_vpc_access_connector), but this is good starting point.

@glasnt
Copy link
Contributor

glasnt commented Sep 27, 2024

@apeabody a lot of these were added in #739 which wasn't merged until after the last periodic.

I didn't add deletion_protection to the samples in this PR because they aren't tested, so don't need to have this. But strictly speaking your PR is correct, all samples should have this argument for completeness.

Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other samples use "# set to "true" in production", but this comment is also fine

@glasnt glasnt merged commit a7a305d into main Sep 27, 2024
9 checks passed
@apeabody apeabody deleted the ap/run branch September 27, 2024 16:08
@apeabody
Copy link
Contributor Author

Other samples use "# set to "true" in production", but this comment is also fine

Thanks @glasnt - Let me know if you would like me to open a PR to replace everywhere, I also copied this syntax from the repo.

@apeabody
Copy link
Contributor Author

@apeabody a lot of these were added in #739 which wasn't merged until after the last periodic.

I didn't add deletion_protection to the samples in this PR because they aren't tested, so don't need to have this. But strictly speaking your PR is correct, all samples should have this argument for completeness.

Gotcha - Yeah, after seeing a few in the test I decided to all to all the google_cloud_run_v2_service. To your point this will reduce friction for those following the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants