Skip to content

chore(CODEOWNERS): Remove unused teams and add cloud-samples-infra #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2024
Merged

chore(CODEOWNERS): Remove unused teams and add cloud-samples-infra #742

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c64413d
chore(CODEOWNERS): Remove unused teams and add cloud-samples-infra as…
grayside Sep 26, 2024
2f43eed
Update .github/CODEOWNERS
grayside Sep 27, 2024
70f4968
Merge branch 'main' into codeowners/remove-unused-add-cloud-samples-i…
glasnt Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,24 @@
# Overall sample owners

* @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/terraform-samples-reviewers
/.github/ @terraform-google-modules/terraform-samples-git-admins
/test/ @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/cft-admins
/build/ @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/cft-admins
/* @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/terraform-samples-reviewers @terraform-google-modules/cloud-samples-infra
/.github/ @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/cloud-samples-infra
/test/ @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/cft-admins @terraform-google-modules/cloud-samples-infra
/build/ @terraform-google-modules/terraform-samples-git-admins @terraform-google-modules/cft-admins @terraform-google-modules/cloud-samples-infra

/bigquery/ @terraform-google-modules/bigquery-terraform-swe @terraform-google-modules/terraform-samples-reviewers
/cloud_scheduler/ @terraform-google-modules/terraform-samples-reviewers
/cloud_sql/ @terraform-google-modules/infra-db-sdk @terraform-google-modules/terraform-samples-reviewers
/cloudvpn/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/composer/ @terraform-google-modules/cloud-dpes-composer @terraform-google-modules/terraform-samples-reviewers
/compute/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/dns/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/eventarc/ @terraform-google-modules/torus-dpe @terraform-google-modules/terraform-samples-reviewers
/functions/ @terraform-google-modules/torus-dpe @terraform-google-modules/terraform-samples-reviewers
/gke/ @terraform-google-modules/eks-team @terraform-google-modules/terraform-samples-reviewers
/lb/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/looker/ @terraform-google-modules/cloud-looker-docs @terraform-google-modules/terraform-samples-reviewers
/looker/ @terraform-google-modules/cloud-looker-docs @terraform-google-modules/terraform-samples-reviewers
/media_cdn/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/network_connectivity/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/privateca/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/run/ @terraform-google-modules/torus-dpe @terraform-google-modules/terraform-samples-reviewers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torus-dpe team is no longer in use and being removed from repositories. Once torus-dpe is removed from this row, the value of keeping this rule as an override seems missing. Is there a need to keep something in place?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see; I believe the intent here is that samples-reviews from the top level will catch this.

I think this isn't entirely best practice, and not something we should be suggesting others do, but given this isn't one of our Big Four, I think it's fine?

(Strictly speaking samples should never be added without expert reviewers, but the fact that in this specific case the expert reviewers moved teams to the superteam, I think it's fine)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarifying, the big four have this, and the intent is that cloud-samples-infra is able to approve things like changes to README, Makefile, and CONTRIBUTING without having authority over the samples themselves. This PR should only have removed unused CODEOWNERS of samples, not moved authority around.

/storage/ @terraform-google-modules/cloud-storage-dpe @terraform-google-modules/terraform-samples-reviewers
/traffic_director/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/vertex_ai/ @terraform-google-modules/dee-data-ai @terraform-google-modules/terraform-samples-reviewers
/vpc/ @terraform-google-modules/dee-infra @terraform-google-modules/terraform-samples-reviewers
/workflows/ @terraform-google-modules/torus-dpe @terraform-google-modules/terraform-samples-reviewers
/managedkafka/ @terraform-google-modules/managedkafka-dev-team @terraform-google-modules/terraform-samples-reviewers
Loading