Skip to content

Conversation

ericgribkoff
Copy link
Contributor

@ericgribkoff ericgribkoff commented Oct 15, 2024

Description

feat(vector search): Add examples for streaming, endpoints, and deploy

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@ericgribkoff ericgribkoff requested review from a team as code owners October 15, 2024 22:56
Copy link

snippet-bot bot commented Oct 15, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae
Copy link
Contributor

iennae commented Oct 16, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Oct 17, 2024

/gcbrun

Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar
Copy link
Contributor

Test cases are passing! Approved the PR and added minor recommendations

CC: @ericgribkoff @glasnt

@glasnt glasnt enabled auto-merge (squash) October 25, 2024 02:58
@glasnt
Copy link
Contributor

glasnt commented Oct 25, 2024

/gcbrun

@glasnt glasnt merged commit 0addd92 into terraform-google-modules:main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants