Skip to content

feat: add sample for flex reservation #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

raushan2016
Copy link

@raushan2016 raushan2016 commented Apr 25, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@apeabody apeabody changed the title Adding sample for flex reservation feat: add sample for flex reservation Apr 25, 2025
@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Apr 25, 2025
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Running terraform fmt
gke/standard/zonal/reservation/main.tf
--- old/gke/standard/zonal/reservation/main.tf
+++ new/gke/standard/zonal/reservation/main.tf
@@ -120,8 +120,8 @@
     total_max_node_count = 1
   }
   node_config {
-    machine_type = "e2-medium"
-    flex_start = true
+    machine_type     = "e2-medium"
+    flex_start       = true
     max_run_duration = "604800s"
 
     reservation_affinity {
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>

@raushan2016
Copy link
Author

/gcbrun

1 similar comment
@apeabody
Copy link
Contributor

/gcbrun

@raushan2016 raushan2016 marked this pull request as ready for review April 25, 2025 23:45
@raushan2016 raushan2016 requested review from a team as code owners April 25, 2025 23:45
Copy link

snippet-bot bot commented Apr 25, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants