Skip to content

Conversation

jarzynskila
Copy link
Contributor

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

  • I have performed tests described in the Contributing guide:

    • Tests pass: terraform apply
      • Above test failed with "Cannot destroy project as deletion_policy is set to PREVENT."
      • Tested in my own project
    • Lint pass: terraform fmt check

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@jarzynskila jarzynskila requested review from a team as code owners August 29, 2025 20:58
Copy link

google-cla bot commented Aug 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

snippet-bot bot commented Aug 29, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt
Copy link
Contributor

glasnt commented Sep 4, 2025

Due to the amount of updates required for this sample, I've opted to edit the PR directly.

I will note some existing terraform samples on the docs page are from https://github.com/terraform-google-modules/terraform-google-network, rather than this repo, but we have the /vpc/ space for samples in this repo.

/gcbrun < this runs the CI

@glasnt glasnt merged commit 2624a8d into terraform-google-modules:main Sep 4, 2025
4 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…oogle-modules#891)

* Prepared network_ipv6 for inclusion in C.G.C. documentation

* ci: skip tests for complex sample

* use standard naming for singleton resource

* correct region tags

* new samples get current date

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants