Skip to content

Conversation

@kushallunkad-google
Copy link

@kushallunkad-google kushallunkad-google commented Sep 24, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@kushallunkad-google kushallunkad-google marked this pull request as ready for review September 24, 2025 06:26
@kushallunkad-google kushallunkad-google requested review from a team as code owners September 24, 2025 06:26
@glasnt glasnt added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 2, 2025
@glasnt
Copy link
Contributor

glasnt commented Oct 2, 2025

Hello @kushallunkad-google. There's a number of issues with this PR that need to be addressed.
Do you have an internal bug I can check to confirm the intent with this sample, and share internal resources to help resolve the issues? Normally we ask this is listed in the PR description, but it appears to be missing.

@glasnt glasnt added waiting-response Waiting for issue author to respond. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 5, 2025
@glasnt glasnt changed the title Fetchbpa feat(backupdr): Add data resource samples Oct 6, 2025
@glasnt glasnt self-assigned this Oct 6, 2025
@glasnt glasnt added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 6, 2025
@glasnt glasnt marked this pull request as draft October 8, 2025 21:24
@glasnt glasnt removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 8, 2025
@glasnt
Copy link
Contributor

glasnt commented Oct 8, 2025

Per internal comms, this PR may no longer be required. Will wait on author to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-response Waiting for issue author to respond.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants