Prevent unnecessary "bastion_vm" replacement when upgrading to 9.x version #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in version
9.0.0
where addingparams
block to an existing bastion host instance would force unnecessary VM replacement.Problem
In the current implementation, the
params
block is always present in thegoogle_compute_instance_from_template.bastion_vm
resource, which causes Terraform to force replacement of the VM when resource_manager_tags are added to an existing instance:Solution
The fix implements a dynamic "params" block that only creates the params configuration when var.resource_manager_tags is not null. This prevents unnecessary VM destruction and recreation when resource manager tags are added or modified.