feat: introduce connection_id for external_table configuration #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdarkhan
requested review from
a team,
ayushmjain,
bradmiro,
davenportjw and
q2w
as code owners
kdarkhan
changed the title
kdarkhan
changed the title
kdarkhan
force-pushed
the
connection-id-external-table
branch
from
3601f5e to
aa7ba73
Compare
|
Hi @q2w, can you please take a look at the PR? I saw you were the most recent reviewer of the updated files. |
kdarkhan
force-pushed
the
connection-id-external-table
branch
from
aa7ba73 to
f509f92
Compare
kdarkhan
force-pushed
the
connection-id-external-table
branch
from
f509f92 to
79e9f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external_data_configurationallows specifyingconnection_idwhich is useful when working with external tables. Ifconnection_idis specified, thenschemaparameter should be moved to the top levelschemafield. If not specified, thenschemashould remain within the existingexternal_data_configurationobject.