Skip to content

Conversation

@rwblokzijl
Copy link
Contributor

When impersonating a service account in the google terraform provider, the background api calls are performed as that service account with one exception. There is one gcloud command being called locally where impersonation is not taken into account. This PR fixes that.

@comment-bot-dev
Copy link

comment-bot-dev commented Mar 30, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rwblokzijl and sorry for the delay!

@rwblokzijl rwblokzijl requested a review from bharathkkb May 23, 2022 11:14
@bharathkkb bharathkkb merged commit 6a7463b into terraform-google-modules:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants