Skip to content

fix: use null as default for lookup #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: use null as default for lookup #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d90a948
use null as default for lookup
cyuanli Aug 8, 2024
80d43c7
set retention period to 1 for example
cyuanli Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/multiple_buckets/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ module "cloud_storage" {
]
}

retention_policy = {
"two" = {
is_locked = false
retention_period = 1
}
}

default_event_based_hold = {
"one" = true
}
Expand Down
6 changes: 3 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,15 @@ resource "google_storage_bucket" "buckets" {
}

dynamic "retention_policy" {
for_each = lookup(var.retention_policy, each.value, {}) != {} ? [var.retention_policy[each.value]] : []
for_each = lookup(var.retention_policy, each.value, null) != null ? [var.retention_policy[each.value]] : []
content {
is_locked = lookup(retention_policy.value, "is_locked", null)
retention_period = lookup(retention_policy.value, "retention_period", null)
}
}

dynamic "custom_placement_config" {
for_each = lookup(var.custom_placement_config, each.value, {}) != {} ? [var.custom_placement_config[each.value]] : []
for_each = lookup(var.custom_placement_config, each.value, null) != null ? [var.custom_placement_config[each.value]] : []
content {
data_locations = lookup(custom_placement_config.value, "data_locations", null)
}
Expand Down Expand Up @@ -149,7 +149,7 @@ resource "google_storage_bucket" "buckets" {
}

dynamic "logging" {
for_each = lookup(var.logging, each.value, {}) != {} ? { v = lookup(var.logging, each.value) } : {}
for_each = lookup(var.logging, each.value, null) != null ? { v = lookup(var.logging, each.value) } : {}
content {
log_bucket = lookup(logging.value, "log_bucket", null)
log_object_prefix = lookup(logging.value, "log_object_prefix", null)
Expand Down
1 change: 1 addition & 0 deletions test/integration/multiple_buckets/multiple_buckets_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func TestMultipleBuckets(t *testing.T) {
gcloud.Run(t, fmt.Sprintf("alpha storage ls --buckets gs://%s/prod/", fullBucketName), gcloudArgs)
bucket_lifecycles := op.Get("metadata.lifecycle.rule").Array()
assert.Equal(1, len(bucket_lifecycles), "Bucket 'two' has 1 lifecycle rule")
assert.Equal("1", op.Get("metadata.retentionPolicy.retentionPeriod").String(), "bucket retention policy retention period is 1")
default:
// fail test if unknown suffix
t.Fatalf("Only expected two buckets with suffixes one and two. Found: %s", fullBucketName)
Expand Down