feat: add dns private zone variable

[nlevee]

In case of multiple cloud composer deployment in multiple shared VPC network, DNS zone drift between deployments

[imrannayer]

/gcbrun

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[nlevee]

Hi, could you check this PR ?

[imrannayer]

/gcbrun

[imrannayer]

@nlevee integration test fails with following error:

estSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185: Error: googleapi: Error 400: Found 1 problem:
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185: 	1) Unsupported image version for new environment: 'composer-2.5.0-airflow-2.6.3'. Currently suggested new environment image versions are: [composer-3-airflow-2.10.2, composer-3-airflow-2.9.3, composer-2.10.1-airflow-2.10.2, composer-2.10.1-airflow-2.9.3]., badRequest
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185: 
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185:   with module.simple-composer.module.simple-composer-environment.google_composer_environment.composer_env,
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185:   on ../../../modules/create_environment_v2/main.tf line 27, in resource "google_composer_environment" "composer_env":
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185:   27: resource "google_composer_environment" "composer_env" {
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z command.go:185: 
TestSimpleComposerEnvV2Module 2025-01-08T17:42:56Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; 
Error: googleapi: Error 400: Found 1 problem:
	1) Unsupported image version for new environment: 'composer-2.5.0-airflow-2.6.3'. Currently suggested new environment image versions are: [composer-3-airflow-2.10.2, composer-3-airflow-2.9.3, composer-2.10.1-airflow-2.10.2, composer-2.10.1-airflow-2.9.3]., badRequest

  with module.simple-composer.module.simple-composer-environment.google_composer_environment.composer_env,
  on ../../../modules/create_environment_v2/main.tf line 27, in resource "google_composer_environment" "composer_env":
  27: resource "google_composer_environment" "composer_env" {
}
    apply.go:34: 
        	Error Trace:	/builder/home/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/apply.go:34
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:571
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:630
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:669
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:669
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: googleapi: Error 400: Found 1 problem:
        	            		1) Unsupported image version for new environment: 'composer-2.5.0-airflow-2.6.3'. Currently suggested new environment image versions are: [composer-3-airflow-2.10.2, composer-3-airflow-2.9.3, composer-2.10.1-airflow-2.10.2, composer-2.10.1-airflow-2.9.3]., badRequest
        	            	
        	            	  with module.simple-composer.module.simple-composer-environment.google_composer_environment.composer_env,
        	            	  on ../../../modules/create_environment_v2/main.tf line 27, in resource "google_composer_environment" "composer_env":
        	            	  27: resource "google_composer_environment" "composer_env" {
        	            	}
        	Test:       	TestSimpleComposerEnvV2Module

[nlevee]

Hi @imrannayer , The default image version in module "create_environment_v2" seem to be invalid, This PR #149 fix this error, can you please check it ?

[imrannayer]

/gcbrun