fix!: Change project as a required input variable
#221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `service_accounts_iam` module uses `var.project` raw in multiple places, with no way of inferring a project ID. The default is misleading, because the module crashes with it.
imrannayer
changed the title
project is a required input variableproject as a required input variable
|
/gcbrun |
apeabody
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Thanks for the contribution @JanCVanB!
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/service_accounts_iam/README.md /tmp/tmp.a9qY6WQIxA/generate_docs/workspace/modules/service_accounts_iam/README.md
[53](https://github.com/terraform-google-modules/terraform-google-iam/actions/runs/10706792069/job/29685307413?pr=221#step:5:54)c53
< | project | Project to add the IAM policies/bindings | `string` | `""` | no |
---
> | project | ID of target project for the IAM policies/bindings | `string` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
service_accounts_iammodule usesvar.projectraw in multiple places, with no way of inferring a project ID. The default is misleading, because the module crashes with it.See https://github.com/terraform-google-modules/terraform-google-iam/blob/master/modules/service_accounts_iam/main.tf#L33-L51