feat: Adding iap_web_backend_services module

[slightsey-recurly]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[slightsey-recurly]

I believe this is ready for review and I have addressed the commit message and CLA requirements. Let me know if there is any additional touch ups needed.

[pkatsovich]

@imrannayer Could you give this a look? We'd love to avoid maintaining a fork. TIA!

[slightsey-recurly]

HI!

@imrannayer Don't want to be annoying. Can I get some eyes on this? Would really appreciate using your repo instead of a fork.

Cheers,
Sam

[imrannayer]

@slightsey-recurly ca u plz fix lint issues. Follow contrib guide

[slightsey-recurly]

Oh yeah. Sorry about that. Linting now.

[slightsey-recurly]

@imrannayer theres a bit of a chicken and egg situation in the linter and examples. The linter can't find the module, but its looking in the remote repository. Following the patters set in the other example modules I don't see how this could ever pass linter until it is merged.

https://github.com/terraform-google-modules/terraform-google-iam/pull/240/files#diff-21031f52eb7c4577e98b0ac3bf99f47806478afb0c215b48091936ea2cacfb2bR21

error:

terraform_validate ./examples/iap_web_backend_services
╷
│ Error: Unreadable module subdirectory
│
│ The directory .terraform/modules/iap_web_backend_services/modules/iap_web_backend_services does not exist. The target submodule modules/iap_web_backend_services does not exist within the target module.

Other than that I think i have addressed all the other linting issues. Sorry about missing those originally.

[imrannayer]

@slightsey-recurly still failing lint test

[slightsey-recurly]

@imrannayer Hi, I know. I wrote an explanation as to why that was happening on the comment above and I don't see how to progress forward without deleting the example unless you have another suggestion?

[bharathkkb]

Hi @slightsey-recurly could you try setting it to the relative path so the swapper ignores this

[imrannayer]

@slightsey-recurly can u check? example code is removed and a lock file is added. Can you plz fix it?

[slightsey-recurly]

@imrannayer I removed the example code. And will submit a PR with correct example code after merge. I don't see how I can get pass the linter until it is merged. See resolved conversation above.

Sorry about the lock file. That is removed.

[imrannayer]

@slightsey-recurly you can pass source path as "../../modules/iap_web_backend_services"

[slightsey-recurly]

Hold on. I may have made an error. Please let me correct.

[slightsey-recurly]

@imrannayer OK! I finally believe we have a solid PR. Used a local path and removed version.

[imrannayer]

/gcbrun

[slightsey-recurly]

Looks like the google cloud build is failing. Lemme know if there is anything i can do to fix.

[slightsey-recurly]

@imrannayer Anything I can do for the cloud build failure?

[slightsey-recurly]

@imrannayer Hi!

Anything I can do here to help?

[imrannayer]

/gcbrun

[imrannayer]

@slightsey-recurly we need some fix in CI/CD pipeline. Waiting for the fix.

[slightsey-recurly]

Any updates on the fix?