Skip to content

feat(TPG>=6.36)!: add storage_pools support #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(TPG>=6.36)!: add storage_pools support #2326

wants to merge 7 commits into from

Conversation

DrFaust92
Copy link
Contributor

this will require a major version bump

@DrFaust92 DrFaust92 requested review from apeabody, ericyz and a team as code owners April 9, 2025 02:13
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

Hold till #2325 is released

@DrFaust92
Copy link
Contributor Author

DrFaust92 commented Apr 12, 2025 •
edited
Loading

apeabody apologies, seems there is no need for node recreate and it is not a breaking change as i first thought.

https://github.com/modular-magician/terraform-provider-google/blob/downstream-pr-cab73525e01fb2ada73ae78520cf58ba1d45fc93/google/services/container/node_config.go#L1917

@DrFaust92
Copy link
Contributor Author

scratch that! https://github.com/modular-magician/terraform-provider-google/blob/downstream-pr-cab73525e01fb2ada73ae78520cf58ba1d45fc93/google/services/container/node_config.go#L440 there is a confusion in upstream. ill open a PR to fix it. meanwhile it can wait

@DrFaust92 DrFaust92 marked this pull request as draft April 12, 2025 20:29
@DrFaust92
Copy link
Contributor Author

GoogleCloudPlatform/magic-modules#13657

@apeabody
Copy link
Collaborator

scratch that! https://github.com/modular-magician/terraform-provider-google/blob/downstream-pr-cab73525e01fb2ada73ae78520cf58ba1d45fc93/google/services/container/node_config.go#L440 there is a confusion in upstream. ill open a PR to fix it. meanwhile it can wait

Thanks!

@DrFaust92 DrFaust92 mentioned this pull request Apr 26, 2025
Open
@DrFaust92
Copy link
Contributor Author

GoogleCloudPlatform/magic-modules#13657 merged upstream

@apeabody
Copy link
Collaborator

apeabody commented May 15, 2025 •
edited
Loading

GoogleCloudPlatform/magic-modules#13657 merged upstream

I suspect "container: allowed in-place update for node_config.storage_pools field in google_container_cluster resource" will be added in TPG v6.36.0

@apeabody
Copy link
Collaborator

GoogleCloudPlatform/magic-modules#13657 merged upstream

I suspect "container: allowed in-place update for node_config.storage_pools field in google_container_cluster resource" will be added in TPG v6.36.0

Added in https://github.com/hashicorp/terraform-provider-google/releases/tag/v6.36.0

DrFaust92 added 5 commits May 29, 2025 23:07
@DrFaust92
storage-pools
967ccec 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92
storage-pools
091bf08 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92
dont require recreate
332af62 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92
rebase
58ce4d9 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92
rebase
2a00aa0 
Signed-off-by: drfaust92 <[email protected]>
DrFaust92 added 2 commits May 29, 2025 23:39
@DrFaust92
rebase
aaaa11d 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92
rebase
1e7f1a4 
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 marked this pull request as ready for review May 30, 2025 03:40
@DrFaust92 DrFaust92 changed the title feat: add storage_pools support feat(TPG>=6.36)!: add storage_pools support May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody Awaiting requested review from apeabody apeabody is a code owner

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @apeabody