feat(safer-cluster): add some missing variables #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
requested changes
Sep 2, 2025
There was a problem hiding this comment.
Thanks for the contribution @bergemalm
Can you please build the templates and add to the commit: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/CONTRIBUTING.md#templating
- node_pools_resource_manager_tags - node_pools_linux_node_configs_sysctls - node_pools_cgroup_mode - node_pools_hugepage_size_2m - node_pools_hugepage_size_1g - enable_secret_manager_addon
bergemalm
force-pushed
the
safer-clusters-missing-variables
branch
from
95b1031 to
49f136d
Compare
Done. @apeabody |
|
/gcbrun |
|
Checking in on this one. Any reason for not adding this one on last release? @apeabody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing variables in the safer-cluster modules.
Closes #2369