-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: additional_ip_ranges_config #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: additional_ip_ranges_config #2458
Conversation
|
/gcbrun |
1c84b6c to
8960c33
Compare
8960c33 to
a82e717
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
Hi @DrFaust92 - I'm going to run the test again, but this is the only PR I'm currently seeing this error: |
|
/gcbrun |
|
Thanks @DrFaust92, still seeing: |
|
I don't think the additional_ip_ranges_config variable needs to be defined as a list... see my comment here -> #2437 (comment) |
db2480a to
faed61b
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
apeabody, can you share the current failure? 🙏 |
Hi @DrFaust92 - Running again as I'm not convinced this is due to the change: |
I'm seeing the same error in #2466 |
|
/gcbrun |
|
Thanks @DrFaust92! This looks great, we just need to add the new integration test to the build: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/build/int.cloudbuild.yaml#L514 Something like this: |
Signed-off-by: drfaust92 <[email protected]>
added |
|
/gcbrun |
1 similar comment
|
/gcbrun |
...ntegration/simple_regional_additional_ip_ranges/simple_regional_additional_ip_ranges_test.go
Outdated
Show resolved
Hide resolved
…egional_additional_ip_ranges_test.go
|
/gcbrun |
|
/gcbrun |
|
Great news @DrFaust92! - The new test is running with two highlights: |
Signed-off-by: drfaust92 <[email protected]>
thanks, remove those checks for test as those are not enabled |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue with the additional_ip_ranges_config dynamic block by using additional_ip_ranges_config.value to access iterated values. The fix is applied consistently across all relevant Terraform module files. Additionally, a new example simple_regional_additional_ip_ranges and a corresponding integration test have been added to validate this functionality. I've found one issue in the new test file where the gcloud command uses an incorrect flag, which I've commented on. Overall, the changes are good and improve the module's functionality and test coverage.
...ntegration/simple_regional_additional_ip_ranges/simple_regional_additional_ip_ranges_test.go
Outdated
Show resolved
Hide resolved
…egional_additional_ip_ranges_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gcbrun |
|
/gcbrun |
apologies, missed this again
Fixes: #2437