feat: allow customizing resource name with prefix & suffix #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baprx ca u plz update templates and follow contribution guide? |
I updated the templates, sorry about that |
|
/gcbrun |
|
Hello @g-awmalik could you please take a look at this PR? thanks |
|
/gcbrun |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
not stale |
baprx
force-pushed
the
feat/variabilize-resource-names
branch
from
d8e56ec to
b9ca96e
Compare
baprx
force-pushed
the
feat/variabilize-resource-names
branch
from
b9ca96e to
f208e48
Compare
baprx
force-pushed
the
feat/variabilize-resource-names
branch
from
f208e48 to
5a75112
Compare
|
/gcbrun |
baprx
force-pushed
the
feat/variabilize-resource-names
branch
from
08cc2dc to
3d2048c
Compare
|
Hello @imrannayer @q2w @g-awmalik can we get this merged please? I'm fairly available to make any adjustments required. |
Signed-off-by: Baptiste Roux <[email protected]>
Signed-off-by: Baptiste Roux <[email protected]>
baprx
force-pushed
the
feat/variabilize-resource-names
branch
from
5160f3a to
06e7838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @bharathkkb,
I'm submitting this PR to revive the issue #268 to allow custom name, very useful when we're dealing with resource imports!
I used the optional variables as mentioned in the linked issue. I added both prefix and suffix options while keeping the existing values as default.
Let me know what you think, I can make adjustments if needed.
I tested the module with existing code without noticing regressions.