-
Notifications
You must be signed in to change notification settings - Fork 393
feat: add support for host and path rules in URL map #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add support for host and path rules in URL map #467
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
When can we expect any progress with this PR? It would be awesome to have such possibility! |
Any update on reviewing this PR? It is a very useful feature. |
Hello, what can we do to push this topic further? |
default = null | ||
} | ||
|
||
variable "host_rules" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwmacedo plz set some default value as this is an optional variable/
})) | ||
} | ||
|
||
variable "path_matchers" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwmacedo plz set some default value as this is an optional variable
@bwmacedo thx for the PR. Can you plz follow contribution guide to generate the code? https://github.com/terraform-google-modules/terraform-google-lb-http/blob/main/CONTRIBUTING.md |
Issue #466
This PR introduces support for host and path rules within the terraform-google-lb-http module, enhancing its flexibility for routing configurations. It adds two new variables, host_rules and path_matchers, to allow users to define custom host-based and path-based routing rules in URL maps. This change enables more granular control over HTTP(S) load balancing behavior, particularly for use cases involving Serverless NEGs (e.g., Cloud Run, App Engine).
Changes:
New Variables:
URL Map Resource Update:
Example Configuration:
Motivation:
This enhancement reduces the need for module customization, making it easier to configure complex load balancing scenarios directly within the module. This is especially beneficial for users with requirements for specific host and path routing logic.
Additional Information:
Documentation updates and additional examples are included to illustrate usage scenarios.