feat: Add support for allowed list of domains for https redirect #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sarnepalli
force-pushed
the
http_redirectrule
branch
3 times, most recently
from
c40fe62 to
47db538
Compare
sarnepalli
force-pushed
the
http_redirectrule
branch
2 times, most recently
from
0694e6a to
19686f5
Compare
sarnepalli
force-pushed
the
http_redirectrule
branch
6 times, most recently
from
dbb551e to
1a1c1a5
Compare
sarnepalli
force-pushed
the
http_redirectrule
branch
from
1a1c1a5 to
94316e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "https_redirect_domains" list variable, serving as an allowlist of valid hosts for HTTP requests that will be redirected to HTTPS.
HTTP requests with a host header not included in the allowlist will not be redirected to HTTPS, and will return a 404 error instead- similar to the HTTPS behavior with invalid host headers.
If https_redirect_domains is not explicitly defined, then by default https_redirect_domains : ["*"] preserves the existing behavior of redirecting all http requests.