Skip to content

Conversation

pawan1210
Copy link
Contributor

No description provided.

@pawan1210 pawan1210 requested review from a team, ayushmjain, imrannayer and q2w as code owners April 3, 2025 15:14
@pawan1210 pawan1210 force-pushed the feat/internal-lb-gce-mig branch 3 times, most recently from c49ae6b to 07d21d9 Compare April 3, 2025 16:02
@pawan1210 pawan1210 force-pushed the feat/internal-lb-gce-mig branch from 07d21d9 to 887dbe0 Compare April 3, 2025 16:49
@pawan1210 pawan1210 force-pushed the feat/internal-lb-gce-mig branch from f7a789f to d010619 Compare April 14, 2025 10:10
variable "firewall_source_ranges" {
description = "Source ranges for the global Application Load Balancer's proxies. This list should contain the `ip_cidr_range` of each GLOBAL_MANAGED_PROXY subnet."
type = list(string)
default = ["10.129.0.0/23"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a default value as 10.127.0.0/23. This is an IP address outside of reserve range of IP addresses for default network. We will have this value as default for Proxy only subnet #501 (review)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pawan1210 pawan1210 force-pushed the feat/internal-lb-gce-mig branch from 59eeaca to e2591f4 Compare April 17, 2025 11:52
@q2w q2w merged commit cfd456f into terraform-google-modules:main Apr 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants