-
Notifications
You must be signed in to change notification settings - Fork 393
feat: Added IAP Principals terraform resource for backend-service #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Added IAP Principals terraform resource for backend-service #528
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4c0b19b
to
9b22215
Compare
description = "Service URI in CAIS style to be used by Apphub." | ||
} | ||
|
||
output "project_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? Input should not be added as output.
description = "Project ID of the service" | ||
} | ||
|
||
output "service_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here!
|
||
|
||
output "project_id" { | ||
value = module.lb-backend-iap.project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly use var.project_id here.
value = module.lb-backend-iap.project_id | |
value = var.project_id |
description = "Project ID of the service" | ||
} | ||
|
||
output "service_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this to be added as output. You can directly use the "backend-with-iap"
in the test file.
|------|-------------| | ||
| apphub\_service\_uri | Service URI in CAIS style to be used by Apphub. | | ||
| backend\_service\_info | Host, path and backend service mapping | | ||
| project\_id | Project ID of the service | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new output variables are not needed.
- backend_service: string | ||
host: string | ||
path: string | ||
- name: project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new output variables are not needed
backendServiceWithIAP.DefineVerify(func(assert *assert.Assertions) { | ||
|
||
projectID := backendServiceWithIAP.GetTFSetupStringOutput("project_id") | ||
serviceName := backendServiceWithIAP.GetStringOutput("service_name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can directly use "backend-with-iap"
as service_name here.
No description provided.