Skip to content

Conversation

Deepraj1996
Copy link

No description provided.

@Deepraj1996 Deepraj1996 requested review from a team, ayushmjain, imrannayer and q2w as code owners August 6, 2025 09:38
Copy link

google-cla bot commented Aug 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Deepraj1996 Deepraj1996 force-pushed the feature/IAP-Enhancement branch from 4c0b19b to 9b22215 Compare August 6, 2025 09:45
@imrannayer imrannayer changed the title feat : Added IAP Principals terraform resource for backend-service feat: Added IAP Principals terraform resource for backend-service Aug 12, 2025
description = "Service URI in CAIS style to be used by Apphub."
}

output "project_id" {
Copy link
Collaborator

@q2w q2w Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? Input should not be added as output.

description = "Project ID of the service"
}

output "service_name" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here!



output "project_id" {
value = module.lb-backend-iap.project_id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly use var.project_id here.

Suggested change
value = module.lb-backend-iap.project_id
value = var.project_id

description = "Project ID of the service"
}

output "service_name" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this to be added as output. You can directly use the "backend-with-iap" in the test file.

|------|-------------|
| apphub\_service\_uri | Service URI in CAIS style to be used by Apphub. |
| backend\_service\_info | Host, path and backend service mapping |
| project\_id | Project ID of the service |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new output variables are not needed.

- backend_service: string
host: string
path: string
- name: project_id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new output variables are not needed

backendServiceWithIAP.DefineVerify(func(assert *assert.Assertions) {

projectID := backendServiceWithIAP.GetTFSetupStringOutput("project_id")
serviceName := backendServiceWithIAP.GetStringOutput("service_name")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can directly use "backend-with-iap" as service_name here.

bryan0515 added a commit to bryan0515/terraform-google-lb-http that referenced this pull request Aug 27, 2025
bryan0515 added a commit to bryan0515/terraform-google-lb-http that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants