feat: Added IAP Principals terraform resource for backend-service #528
Conversation
Deepraj1996
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Deepraj1996
force-pushed
the
feature/IAP-Enhancement
branch
from
4c0b19b to
9b22215
Compare
imrannayer
changed the title
| description = "Service URI in CAIS style to be used by Apphub." | ||
| } | ||
|
|
||
| output "project_id" { |
There was a problem hiding this comment.
Why do we need this? Input should not be added as output.
| description = "Project ID of the service" | ||
| } | ||
|
|
||
| output "service_name" { |
|
|
||
|
|
||
| output "project_id" { | ||
| value = module.lb-backend-iap.project_id |
There was a problem hiding this comment.
You can directly use var.project_id here.
| value = module.lb-backend-iap.project_id | |
| value = var.project_id |
| description = "Project ID of the service" | ||
| } | ||
|
|
||
| output "service_name" { |
There was a problem hiding this comment.
We don't need this to be added as output. You can directly use the "backend-with-iap" in the test file.
| |------|-------------| | ||
| | apphub\_service\_uri | Service URI in CAIS style to be used by Apphub. | | ||
| | backend\_service\_info | Host, path and backend service mapping | | ||
| | project\_id | Project ID of the service | |
There was a problem hiding this comment.
These new output variables are not needed.
| - backend_service: string | ||
| host: string | ||
| path: string | ||
| - name: project_id |
There was a problem hiding this comment.
These new output variables are not needed
| backendServiceWithIAP.DefineVerify(func(assert *assert.Assertions) { | ||
|
|
||
| projectID := backendServiceWithIAP.GetTFSetupStringOutput("project_id") | ||
| serviceName := backendServiceWithIAP.GetStringOutput("service_name") |
There was a problem hiding this comment.
Can directly use "backend-with-iap" as service_name here.
3 participants
No description provided.