feat: Adding support for PSC NEGs in terraform-google-lb-http/modules/backend #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkaczor
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
nkaczor
force-pushed
the
feature/psc_negs
branch
2 times, most recently
from
b2d374d to
46efddd
Compare
nkaczor
force-pushed
the
feature/psc_negs
branch
from
46efddd to
bcd7d3d
Compare
nkaczor
changed the title
pawan1210
reviewed
Sep 18, 2025
…it in backend module and example
pawan1210
approved these changes
Sep 18, 2025
q2w
reviewed
Sep 25, 2025
There was a problem hiding this comment.
You will need to add the test in the cloudbuild.yaml file. https://github.com/terraform-google-modules/terraform-google-lb-http/blob/main/build/int.cloudbuild.yaml#L162-L181
q2w
approved these changes
Sep 26, 2025
nkaczor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.