Skip to content

feat: added producer VPC network spoke #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2025
Merged

feat: added producer VPC network spoke #634

merged 3 commits into from
Sep 3, 2025

Conversation

imrannayer
Copy link
Collaborator

fix #621

@imrannayer imrannayer requested a review from a team as a code owner September 2, 2025 19:32
@imrannayer imrannayer self-assigned this Sep 2, 2025
@apeabody
Copy link
Contributor

apeabody commented Sep 2, 2025

Hi @imrannayer - Should also add

      lint_env = {
        ENABLE_BPMETADATA = "1"
      }

to https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/main/infra/terraform/test-org/org/locals.tf#L226

@imrannayer
Copy link
Collaborator Author

imrannayer commented Sep 2, 2025 •
edited
Loading

@apeabody done

GoogleCloudPlatform/cloud-foundation-toolkit#3178

@apeabody apeabody mentioned this pull request Sep 2, 2025
Merged
@imrannayer
Copy link
Collaborator Author

@apeabody can u plz review?

apeabody
apeabody approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imrannayer!

One note below before merging.

@imrannayer imrannayer merged commit d79ab8b into terraform-google-modules:main Sep 3, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@imrannayer imrannayer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add 'linked_producer_vpc_network' to 'google_network_connectivity_spoke'

2 participants

@imrannayer @apeabody