-
Notifications
You must be signed in to change notification settings - Fork 140
feat: Issue #208: Add no_wrapper settings in push_config #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue #208: Add no_wrapper settings in push_config #218
Conversation
Hi @imrannayer , @apeabody did anyone of you already had the opportunity to look at this PR? Getting the |
/gcbrun |
Thanks for the contribution @geryonghost! I've updated against main, and triggered the CI tests. Either @imrannayer or a member of @api-pubsub-and-pubsublite should provide the final review. Cheers! |
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @geryonghost! A few quick notes:
Co-authored-by: Andrew Peabody <[email protected]>
Co-authored-by: Andrew Peabody <[email protected]>
/gcbrun |
Thanks @geryonghost - This change looks good with the existing tests, can you please update one of the examples to use the new setting, so they are also testing with something other than just the default |
@apeabody good morning, I would like to get this PR merged. It has been quite a while. This is my first community submission so I am still learning how to get this done. I fear to update the branch because that always break |
/gcbrun |
The linter appears stuck - going to close and re-open the PR |
/gcbrun |
Hi @geryonghost! The initial test "failed" behavior is expected as the tests need to be triggered by a member. I've updated the branch and triggered the tests which are now running. Either @imrannayer or a member of @api-pubsub-and-pubsublite should provide the final review. Thanks! |
My comments have been addressed, pending final review and approval by a repo maintainer. Thanks!
:bump: for a repo maintainer |
@ayushmjain, @imrannayer, @q2w, @terraform-google-modules/api-pubsub-and-pubsublite, and/or @terraform-google-modules/cft-admins can you look at this please. |
The
push_config
forresource "google_pubsub_subscription" "push_subscriptions"
doesn't include theno_wrapper
settings. This has been added.