Skip to content

Conversation

ktinubu
Copy link
Contributor

@ktinubu ktinubu commented Jan 28, 2025

Add connection metadata:

  • bigquery module output table_ids[0] -> bigquery_subscription table (uses first table_id)
  • Cloud storage module output name -> cloud_storage_subscription bucket

Note: bigquery is not available yet in ADC

BEGIN_COMMIT_OVERRIDE
fix: migrate bigquery_subscription and cloud_storage_subscription variables to objects (#222)
END_COMMIT_OVERRIDE

@ktinubu ktinubu requested a review from q2w January 28, 2025 19:57
@ktinubu ktinubu self-assigned this Jan 28, 2025
@ktinubu ktinubu requested review from a team and imrannayer as code owners January 28, 2025 19:57
@ktinubu ktinubu assigned q2w and unassigned ktinubu Jan 29, 2025
@ktinubu ktinubu requested a review from a team as a code owner January 31, 2025 15:24
@ktinubu ktinubu requested a review from q2w February 5, 2025 16:04
@ktinubu ktinubu requested a review from apeabody February 6, 2025 15:29
@ktinubu ktinubu requested a review from lahuang4 February 7, 2025 01:15
@lahuang4 lahuang4 merged commit 8b06b62 into terraform-google-modules:main Feb 7, 2025
4 checks passed
@ktinubu ktinubu added the release-please:force-run Force release-please to check for changes. label Feb 7, 2025
@release-please release-please bot removed the release-please:force-run Force release-please to check for changes. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants