Feat: Add missing attribute no_wrapper option to push subscription #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ram1604
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
Ram1604
changed the title
Ram1604
changed the title
Ram1604
changed the title
|
Hi @imrannayer @ayushmjain @q2w Can you please check on this? |
|
Hi @imrannayer @ayushmjain @q2w Can you check on this? |
|
Hi @imrannayer @ayushmjain @q2w Following up on this. |
|
Hi @imrannayer @q2w @ayushmjain When can I expect this to be reviewed? |
|
/gcbrun |
|
Thanks for running the build. When can I expect this to be merged? |
apeabody
reviewed
Mar 27, 2025
| filter = optional(string), | ||
| enable_message_ordering = optional(bool), | ||
| })) | ||
| varType: "list(object({\r\n name = string,\r\n ack_deadline_seconds = optional(number),\r\n push_endpoint = optional(string),\r\n x-goog-version = optional(string),\r\n oidc_service_account_email = optional(string),\r\n audience = optional(string),\r\n expiration_policy = optional(string),\r\n dead_letter_topic = optional(string),\r\n retain_acked_messages = optional(bool),\r\n message_retention_duration = optional(string),\r\n max_delivery_attempts = optional(number),\r\n maximum_backoff = optional(string),\r\n minimum_backoff = optional(string),\r\n filter = optional(string),\r\n enable_message_ordering = optional(bool),\r\n no_wrapper = optional(bool),\r\n write_metadata = optional(bool),\r\n }))" |
There was a problem hiding this comment.
I haven't seen this formatting before, is this correct? @q2w?
There was a problem hiding this comment.
@Ram1604 Hey, Did you use the make generate_docs to update the metadata.yaml?
There was a problem hiding this comment.
@q2w I did ran it after that the metadata.yaml got updated.
|
Hi @q2w Can you kindly assist here? |
|
Can you please assist here? |
q2w
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is not added in the push subscription. This option is needed to enable or disable "Push payload unwrapping" from the module itself.