feat: Add disabled flag #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
Jul 22, 2025
variables.tf
Outdated
| } | ||
|
|
||
| variable "disabled" { | ||
| type = bool |
There was a problem hiding this comment.
Could we expose this as a map of bools? I am thinking if there is a case where users may want to disable only a subset of SAs the module manages.
There was a problem hiding this comment.
@bharathkkb -- great idea. updated!
lawrenae
force-pushed
the
add_disabled_flag
branch
from
fd7cdd2 to
7691045
Compare
|
/gcbrun |
|
/gcbrun |
bharathkkb
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to set and retrieve the disabled flag for all service accounts.