Skip to content

fix: Adding UI validations for MiG and instance template #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+334 −1
Open

fix: Adding UI validations for MiG and instance template #521

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f184d6
Adding UI validations for MiG and instance template
amrkk123 Aug 12, 2025
b20e1b7
Removing whitespaces
amrkk123 Aug 12, 2025
9747732
Remove remaining whitespace
amrkk123 Aug 12, 2025
bc17514
Fixing whitespace
amrkk123 Aug 19, 2025
4a4559e
Fixing whitespace
amrkk123 Aug 19, 2025
0f6a66c
changing regex for network and subnetwork
amrkk123 Aug 20, 2025
5eca863
fix whitespace
amrkk123 Aug 20, 2025
f76d43b
fixing escape for regex
amrkk123 Aug 22, 2025
2eb1e93
fix regex escape in instance template and mig
amrkk123 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 200 additions & 7 deletions modules/instance_template/metadata.display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,17 @@ spec:
access_config:
name: access_config
title: Access Config
properties:
network_tier:
name: network_tier
title: Network Tier
enumValueLabels:
- label: PREMIUM
value: PREMIUM
- label: STANDARD
value: STANDARD
- label: FIXED_STANDARD
value: FIXED_STANDARD
altDefaults:
- type: ALTERNATE_TYPE_DC
value:
Expand All @@ -39,25 +50,141 @@ spec:
additional_disks:
name: additional_disks
title: Additional Disks
properties:
disk_type:
name: disk_type
title: Disk Type
enumValueLabels:
- label: pd-standard
value: pd-standard
- label: pd-balanced
value: pd-balanced
- label: pd-ssd
value: pd-ssd
- label: local-ssd
value: local-ssd
- label: hyperdisk-balanced
value: hyperdisk-balanced
- label: hyperdisk-throughput
value: hyperdisk-throughput
- label: hyperdisk-extreme
value: hyperdisk-extreme
interface:
name: interface
title: Interface
enumValueLabels:
- label: SCSI
value: SCSI
- label: NVME
value: NVME
mode:
name: mode
title: Mode
enumValueLabels:
- label: READ_WRITE
value: READ_WRITE
- label: READ_ONLY
value: READ_ONLY
additional_networks:
name: additional_networks
title: Additional Networks
properties:
network:
name: network
title: Network
regexValidation: ^(?:projects\/[a-z0-9-]+\/)?global\/networks\/[a-z0-9-]{1,63}$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just network name is also allowed here.

validation: Invalid network format. Must be a network name or a self link.
subnetwork:
name: subnetwork
title: Subnetwork
regexValidation: ^(?:projects\/[a-z0-9-]+\/)?(?:regions\/[a-z0-9-]+\/)?subnetworks\/[a-z0-9-]{1,63}$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

validation: Invalid subnetwork format. Must be a subnetwork name or a self link.
network_ip:
name: network_ip
title: Network Ip
regexValidation: ^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

validation: Invalid IP address format. Must be a valid IPv4 address.
nic_type:
name: nic_type
title: Nic Type
enumValueLabels:
- label: VIRTIO_NET
value: VIRTIO_NET
- label: GVNIC
value: GVNIC
- label: MRDMA
value: MRDMA
- label: IRDMA
value: IRDMA
stack_type:
name: stack_type
title: Stack Type
enumValueLabels:
- label: IPV4_ONLY
value: IPV4_ONLY
- label: IPV6_ONLY
value: IPV6_ONLY
- label: IPV4_IPV6
value: IPV4_IPV6
access_config:
name: access_config
title: Access Config
properties:
network_tier:
name: network_tier
title: Network Tier
enumValueLabels:
- label: PREMIUM
value: PREMIUM
- label: STANDARD
value: STANDARD
- label: FIXED_STANDARD
value: FIXED_STANDARD
ipv6_access_config:
name: ipv6_access_config
title: Ipv6 Access Config
properties:
network_tier:
name: network_tier
title: Network Tier
enumValueLabels:
- label: PREMIUM
value: PREMIUM
- label: STANDARD
value: STANDARD
alias_ip_range:
name: alias_ip_range
title: Alias Ip Range
auto_delete:
name: auto_delete
title: Auto Delete
enumValueLabels:
- label: "true"
value: "true"
- label: "false"
value: "false"
automatic_restart:
name: automatic_restart
title: Automatic Restart
level: 1
can_ip_forward:
name: can_ip_forward
title: Can Ip Forward
enumValueLabels:
- label: "false"
value: "false"
- label: "true"
value: "true"
confidential_instance_type:
name: confidential_instance_type
title: Confidential Instance Type
enumValueLabels:
- label: SEV
value: SEV
- label: SEV_SNP
value: SEV_SNP
- label: TDX
value: TDX
create_service_account:
name: create_service_account
title: Create Service Account
Expand All @@ -83,6 +210,21 @@ spec:
name: disk_type
title: Disk Type
level: 1
enumValueLabels:
- label: pd-standard
value: pd-standard
- label: pd-balanced
value: pd-balanced
- label: pd-ssd
value: pd-ssd
- label: local-ssd
value: local-ssd
- label: hyperdisk-balanced
value: hyperdisk-balanced
- label: hyperdisk-throughput
value: hyperdisk-throughput
- label: hyperdisk-extreme
value: hyperdisk-extreme
enable_confidential_vm:
name: enable_confidential_vm
title: Enable Confidential Vm
Expand All @@ -102,6 +244,15 @@ spec:
ipv6_access_config:
name: ipv6_access_config
title: Ipv6 Access Config
properties:
network_tier:
name: network_tier
title: Network Tier
enumValueLabels:
- label: PREMIUM
value: PREMIUM
- label: STANDARD
value: STANDARD
labels:
name: labels
title: Labels
Expand All @@ -112,42 +263,63 @@ spec:
maintenance_interval:
name: maintenance_interval
title: Maintenance Interval
enumValueLabels:
- label: PERIODIC
value: PERIODIC
metadata:
name: metadata
title: Metadata
min_cpu_platform:
name: min_cpu_platform
title: Min Cpu Platform
enumValueLabels:
- label: Intel Haswell
value: Intel Haswell
- label: Intel Skylake
value: Intel Skylake
name_prefix:
name: name_prefix
title: Name Prefix
regexValidation: ^[a-z][a-z0-9-]{0,51}[a-z0-9]$
validation: Use lowercase letters, numbers, and hyphens. Start with a letter and end with letter/number. Must be 53 characters or fewer.
regexValidation: ^.{1,54}$
validation: Name prefix must be 54 characters or less.
level: 1
network:
name: network
title: Network
level: 1
regexValidation: ^(?:projects\/[a-z0-9-]+\/)?global\/networks\/[a-z0-9-]{1,63}$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network name is not getting passed here.

validation: Invalid network format. Must be a network name or a self link.
altDefaults:
- type: ALTERNATE_TYPE_DC
value: default
network_ip:
name: network_ip
title: Network Ip
regexValidation: ^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$
validation: Invalid IP address format. Must be a valid IPv4 address.
nic_type:
name: nic_type
title: Nic Type
enumValueLabels:
- label: VIRTIO_NET
value: VIRTIO_NET
- label: GVNIC
value: GVNIC
- label: MRDMA
value: MRDMA
- label: IRDMA
value: IRDMA
on_host_maintenance:
name: on_host_maintenance
title: On Host Maintenance
enumValueLabels:
- label: MIGRATE
value: MIGRATE
- label: TERMINATE
value: TERMINATE
preemptible:
name: preemptible
title: Preemptible
enumValueLabels:
- label: "true"
value: "true"
- label: "false"
value: "false"
project_id:
name: project_id
title: Project Id
Expand All @@ -168,6 +340,8 @@ spec:
service_account_project_roles:
name: service_account_project_roles
title: Service Account Project Roles
regexValidation: ^(roles\/[a-zA-Z0-9_\\.]+|(projects\/[a-z][a-z0-9\\-]{4,28}[a-z0-9]|organizations\/[0-9]+)\/roles\/[a-zA-Z0-9_]+)$
validation: Role must be a valid Google Cloud IAM role name, in the format of 'roles/{role_name}'.
shielded_instance_config:
name: shielded_instance_config
title: Shielded Instance Config
Expand All @@ -189,16 +363,30 @@ spec:
spot_instance_termination_action:
name: spot_instance_termination_action
title: Spot Instance Termination Action
enumValueLabels:
- label: STOP
value: STOP
- label: DELETE
value: DELETE
stack_type:
name: stack_type
title: Stack Type
enumValueLabels:
- label: IPV4_ONLY
value: IPV4_ONLY
- label: IPV4_IPV6
value: IPV4_IPV6
- label: IPV6_ONLY
value: IPV6_ONLY
startup_script:
name: startup_script
title: Startup Script
subnetwork:
name: subnetwork
title: Subnetwork
level: 1
regexValidation: ^(?:projects\/[a-z0-9-]+\/)?(?:regions\/[a-z0-9-]+\/)?subnetworks\/[a-z0-9-]{1,63}$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just name is not getting passed here.

validation: Invalid subnetwork format. Must be a subnetwork name or a self link.
subnetwork_project:
name: subnetwork_project
title: Subnetwork Project
Expand All @@ -212,3 +400,8 @@ spec:
total_egress_bandwidth_tier:
name: total_egress_bandwidth_tier
title: Total Egress Bandwidth Tier
enumValueLabels:
- label: DEFAULT
value: DEFAULT
- label: TIER_1
value: TIER_1
Loading