feat: initial module + DA #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
ocofaigh
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Many of the same comments that I already left in the cloud logs agent PR. Please try to be more consistent.
- Diagram updates:
- Resource Group -> Existing resource group
- data -> metrics
- Monitoring Instance -> Existing Monitoring instance
- Move Monitoring instance icon outside of resource group. It doesn't have to be in the same RG as the cluster.
- update codeowners
- update
.github/settings.ymlwith descrption - update
.releasercto trigger catalog pipeline
|
/run pipeline |
|
|
ocofaigh
requested changes
Apr 24, 2025
ocofaigh
reviewed
Apr 24, 2025
ocofaigh
requested changes
Apr 25, 2025
variables.tf
Outdated
| nullable = false | ||
| } | ||
|
|
||
| variable "instance_region" { |
There was a problem hiding this comment.
I think this one should be prefixed with cloud_monitoring_:
cloud_monitoring_instance_region
variables.tf
Outdated
| nullable = false | ||
| } | ||
|
|
||
| variable "endpoint_type" { |
There was a problem hiding this comment.
I think this one should be prefixed with cloud_monitoring_instance:
cloud_monitoring_instance_endpoint_type
ocofaigh
requested changes
Apr 25, 2025
variables.tf
Outdated
| variable "chart_version" { | ||
| description = "The version of the Cloud Monitoring agent helm chart to deploy." | ||
| type = string | ||
| default = "1.79.0" # Replace with the desired version |
There was a problem hiding this comment.
For renovate to manage this, please change to:
Suggested change
| default = "1.79.0" # Replace with the desired version | |
| default = "1.79.0" # registryUrl: charts.sysdig.com |
There was a problem hiding this comment.
You also need to update the renovate.json file with the following contents:
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>terraform-ibm-modules/common-dev-assets:commonRenovateConfig"],
"customManagers": [
{
"customType": "regex",
"description": "Update docker image digest to latest in variables.tf",
"fileMatch": ["variables.tf$"],
"datasourceTemplate": "docker",
"matchStrings": [
"default\\s*=\\s*\"(?<currentValue>[\\w.-]+)@(?<currentDigest>sha256:[a-f0-9]+)\"\\s*# datasource: (?<depName>[^\\s]+)"
]
},
{
"customType": "regex",
"description": "Update sysdig-deploy helm chart version to latest in variables.tf",
"fileMatch": ["variables.tf$"],
"matchStrings": ["default\\s*=\\s*\"(?<currentValue>.*?)\"\\s*# registryUrl: charts.sysdig.com\\n"],
"depNameTemplate": "sysdig-deploy",
"datasourceTemplate": "helm",
"registryUrlTemplate": "https://charts.sysdig.com"
}
],
"packageRules": [
{
"description": "Bundle image + helm chart updates into the same PR",
"matchPackageNames": ["icr.io/ext/sysdig/agent", "sysdig-deploy"],
"groupName": "Charts and Images",
"commitMessageExtra": "to latest",
"group": true
}
]
}
ocofaigh
approved these changes
Apr 25, 2025
|
/run pipeline |
|
Test failed with: Unrelated to changes in this PR so re-running.. |
|
/run pipeline |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers