Add Ivy DI#157
Open
ILIYANGERMANOV wants to merge 2 commits into
Open
Conversation
Author
|
@terrakok can you please review? 👀 |
Author
Thanks @terrakok! Updated the PR description with the required info. Can you re-review? 🙏 |
Author
|
Btw, you can setup a CONTRIBUTING.MD in the repo so GitHub will automatically prompt folks to read the guidelines before opening PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds https://github.com/Ivy-Apps/di
every suggesion should contain link to any project uses the library (not an author's sample)
https://github.com/Ivy-Apps/learn ✅
the library is supposed to support Android + iOS targets
Supports all targets ✅
the library must be published to the MavenCentral
https://central.sonatype.com/artifact/com.ivy-apps/di ✅
the library should be a popular (github stars ~ 50, at least) 🟡
Kinda there, it was launched officially and posted publicly a few days so it should reach the 50 mark soon. Currently, it's at 33. For more info see:
https://github.com/Ivy-Apps/di?tab=readme-ov-file#star-history