Increase timeout to wait for a job #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test often "randomly" fails waiting for the job, but using 100ms seems either a typo or way to short. This now increases the timeout to 10 seconds, this will make the test slow in case of real failures but these should not happen anyways in the usual case. If the test still fails we need to further investigate whats going on.
Test Results 216 files + 216 216 suites +216 19m 3s ⏱️ + 19m 3s For more details on these failures, see this check. Results for commit f447c65. ± Comparison against base commit da85ee3. ♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
increase_wait_for_job
branch
from
e2b7a01 to
f447c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test often "randomly" fails waiting for the job, but using 100ms seems either a typo or way to short.
This now increases the timeout to 10 seconds, this will make the test slow in case of real failures but these should not happen anyways in the usual case. If the test still fails we need to further investigate whats going on.