Skip to content

Conversation

@DCjanus
Copy link
Contributor

@DCjanus DCjanus commented Nov 18, 2025

Close #786

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit 54e309f
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-rust/deploys/691c1f2ce293060009f3a863
😎 Deploy Preview https://deploy-preview-878--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@DCjanus DCjanus marked this pull request as draft November 18, 2025 07:25
.await?;

// assert file mode
let mut res = container
Copy link

@darth-raijin darth-raijin Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it improve the test quality to structure the assertions as a small table test?

Right now each file/path/assertion is written out separately, but the test follows a pattern:

  • Three inputs (file, directory, bytes)
  • Each input ends up at a known path inside the container
  • Each path has an expected mode that we assert with stat

Representing these as a tiny table (e.g. struct { path, expected_mode } and iterating) would:

  • Reduce repetition
  • Keep the expected paths and modes in one place
  • Make the test easier to extend or refactor in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Add file permission to CopyToContainer

2 participants