fix(await-async-queries): false positive with optional chaining #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
+ Coverage 96.27% 96.29% +0.01%
==========================================
Files 46 47 +1
Lines 2472 2483 +11
Branches 1025 1026 +1
==========================================
+ Hits 2380 2391 +11
Misses 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
changed the title
await-async-queries has false positive with optional chaining
Belco90
reviewed
May 16, 2025
| @@ -93,6 +93,9 @@ ruleTester.run(RULE_NAME, rule, { | |||
| // async screen queries declaration are valid | |||
| ...createTestCase((query) => `await screen.${query}('foo')`), | |||
|
|
|||
| // async queries with optional chaining are valid | |||
There was a problem hiding this comment.
suggestion(blocking): This is nice, but please add also another test for the exact scenario reported in #882 description.
…t-async-queries-optional-chaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #882