Add TypeScript Examples to vue-testing-library#1463
Merged
MatanBobi merged 1 commit intotesting-library:mainfrom May 2, 2025
aburdiss:main
Merged
Add TypeScript Examples to vue-testing-library#1463MatanBobi merged 1 commit intotesting-library:mainfrom aburdiss:main
MatanBobi merged 1 commit intotesting-library:mainfrom
aburdiss:main
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timdeschryver
approved these changes
Dec 27, 2024
Member
timdeschryver
left a comment
timdeschryver
left a comment
There was a problem hiding this comment.
This looks good to me 👍
I'll leave this open a while longer so others can also review, otherwise i'll merge this next week.
Member
|
Thanks @aburdiss! |
Contributor
|
@aburdiss already contributed before to doc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the React Testing Library Docs, there are TypeScript examples, but these do not exist on most other pages.
I believe that it's useful for TypeScript examples to exist on other pages as well, especially examples, and even if they're extremely similar to the JavaScript examples, because this makes it more accessible to newer developers.
Disclosure: I'm newer to VueJS and TypeScript (coming from JS/React), and have been reading the docs myself to get this set up on my end, so if anyone notices better ways of handling these examples I'm not attached to the code inside.