Merged
Conversation
Owner
|
The failed android build is because the Base64 header still needs to include |
jjuhl
force-pushed
the
random-changes
branch
3 times, most recently
from
245e729 to
2afbc6f
Compare
Contributor
Author
Yeah, I tried that and it also needed StringView.hpp, but even after adding those I still got failures, so in the end I just dropped all the changes to the files that caused issues - it can always be revisited some other time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few random things I've noticed while browsing through the code.