fix(store): correct no-op slice element removal in matchesExternalLabels - #8927
Open
magic-peach wants to merge 1 commit into
Open
fix(store): correct no-op slice element removal in matchesExternalLabels#8927magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
GiedriusS
reviewed
Jul 19, 2026
GiedriusS
left a comment
GiedriusS
left a comment
Member
There was a problem hiding this comment.
Could you add unit tests for this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug
append(tms[:i], tms[i:]...)is a no-op — it reconstructs the same slice without removing element at indexi. The correct expression isappend(tms[:i], tms[i+1:]...). This bug exists in bothpkg/store/prometheus.goandpkg/exemplars/proxy.go.Fix
Change
tms[i:]...totms[i+1:]...in both files.