Skip to content

fix(border painter): improve fill validation for paint edge.cuts with (fill: no) in kicad_pcb #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

fix(border painter): improve fill validation for paint edge.cuts with (fill: no) in kicad_pcb #111

merged 2 commits into from
Jun 13, 2025

Conversation

boluo-O
Copy link
Contributor

@boluo-O boluo-O commented May 11, 2025

fix #107

test file test.zip

before
image

after
image

@boluo-O boluo-O changed the title fix(border painter): improve fill validation for paint edge.cuts with (fill: no) in kicad_sch fix(border painter): improve fill validation for paint edge.cuts with (fill: no) in kicad_pcb May 12, 2025
stonedDiscord
stonedDiscord approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@stonedDiscord stonedDiscord left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the issue.

makes it work with kicad 9 files.

@stonedDiscord
Copy link
Contributor

Hey @theacodes 👋🏻,
I know you don't have much time for this project anymore,
but I hope you can find a minute now that OSHWA 2025 is over.
Without this fix, boards created in KiCAD 9 (and probably newer) fail to be displayed properly, as this doesn't only affect the edge cut layer.
I use this project a lot to show people new to electronics what can be done with KiCAD, without making them download the entire thing.
🙏🏻 Thank you for your time.

@theacodes
Copy link
Owner

Looks great, thank you for doing this! & thank you for the ping, I definitely have time to review PRs. :)

@theacodes
Copy link
Owner

Looks like there's a small lint issue, do you mind fixing that? Once it's good, I'll merge. :)

stonedDiscord
stonedDiscord reviewed Jun 6, 2025
View reviewed changes
src/viewers/board/painter.ts Outdated
return (this.view_painter as BoardPainter).filter_net;
}

protected isFillValid(fill: string ): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier doesn't like the space after string

@boluo-O
Copy link
Contributor Author

boluo-O commented Jun 10, 2025

The lint error has been fixed and is this PR ready to be merged now ？Let me know if there's anything else that needs adjusting. @theacodes @stonedDiscord

@theacodes
Copy link
Owner

Yes, looks wonderful! Thank you, sorry for taking so long to review again. :)

@theacodes theacodes merged commit 82960b5 into theacodes:main Jun 13, 2025
2 checks passed
@stonedDiscord
Copy link
Contributor

stonedDiscord commented Jul 4, 2025 •
edited
Loading

Hi,

I was wondering when the version running on https://kicanvas.org gets updated to reflect the changes?
I've openend a PR to address this #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stonedDiscord stonedDiscord stonedDiscord approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KiCad 9, filled Edge.Cuts

3 participants

@boluo-O @stonedDiscord @theacodes