Support for embedding source in kicanvas-source #126
Conversation
| return; | ||
| } | ||
|
|
||
| await this.#setup_project( |
There was a problem hiding this comment.
instead of three separate invocations of await this.#setup_project, have the preceding code construct a vfs and then have the last statement be:
return await #this.setup_project(vfs);
| continue; | ||
| } | ||
|
|
||
| let filename = src_elm.name?.trim(); |
There was a problem hiding this comment.
Because querySelectorAll is used, the custom element property is not reliably accessible and may return undefined at runtime. To address this problem, getAttribute should be used on the returned element.
I've changed this to src_elm.getAttribute('name')?.trim() in my local copy to resolve the issue.
There was a problem hiding this comment.
Interesting - I'm wondering if this is executing before the element has finished being registered?
|
|
||
| let filename = src_elm.name?.trim(); | ||
| if (!filename || filename.length == 0) { | ||
| const type = (src_elm.type ?? "schematic").toLowerCase(); |
There was a problem hiding this comment.
Similarly to the comment above I've changed this to src_elm.getAttribute('type') in my local copy to resolve the issue.
There was a problem hiding this comment.
I've tested this change as it's useful for my own project, and found that at runtime the code won't have the name and type custom properties reliably available when accessing elements through querySelectorAll. To address the problem it is recommended to use getAttribute to access the two custom attributes.
3 participants
No description provided.