Skip to content

Add deprecation warning for ACD plugin#4420

Merged
maximiliankolb merged 1 commit intotheforeman:3.16from
ATIX-AG:acd_deprecation
Feb 23, 2026
Merged

Add deprecation warning for ACD plugin#4420
maximiliankolb merged 1 commit intotheforeman:3.16from
ATIX-AG:acd_deprecation

Conversation

@maximiliankolb
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb commented Oct 24, 2025

What changes are you introducing?

Foreman 3.17 does not support foreman_acd and smart_proxy_acd.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

follow-up to #4359 (Remove docs for foreman_acd from nightly)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Note that the package is currently still present on https://yum.theforeman.org/plugins/nightly/el9/x86_64/.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Oct 24, 2025

draft PR until I know how this actually works.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 24, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 24, 2025 •
edited
Loading

The PR preview for d9f6735 is available at theforeman-foreman-documentation-preview-pr-4420.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Nov 6, 2025

Refs ATIX-AG/foreman_acd#50

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 20, 2026
@maximiliankolb maximiliankolb marked this pull request as ready for review February 20, 2026 12:24
aneta-petrova
aneta-petrova reviewed Feb 23, 2026
View reviewed changes
Comment thread guides/doc-Release_Notes/topics/foreman.adoc Outdated
Comment thread guides/doc-Release_Notes/topics/foreman.adoc Outdated
Comment thread guides/doc-Release_Notes/topics/foreman.adoc Outdated
@aneta-petrova
Copy link
Copy Markdown
Member

aneta-petrova commented Feb 23, 2026

I don't actually see the removal in https://docs.theforeman.org/3.17/Release_Notes/index-katello.html. Should it be there?

@maximiliankolb
Add deprecation warning for ACD plugin
d9f6735 
Foreman 3.17 does not support foreman_acd and smart_proxy_acd.

Refs theforeman#4359 (Remove docs for foreman_acd from nightly)
maximiliankolb
maximiliankolb commented Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied all three suggestions. Ready for re-review.

Yes, 3.17 currently lacks any info on ACD. If we merge this, I should probably also create a PR against 3.17.

Comment thread guides/doc-Release_Notes/topics/foreman.adoc Outdated
Comment thread guides/doc-Release_Notes/topics/foreman.adoc Outdated
Comment thread guides/doc-Release_Notes/topics/foreman.adoc Outdated
@maximiliankolb maximiliankolb added the style review done No issues from docs style/grammar perspective label Feb 23, 2026
@maximiliankolb maximiliankolb merged commit c2c42ca into theforeman:3.16 Feb 23, 2026
8 of 9 checks passed
@maximiliankolb maximiliankolb deleted the acd_deprecation branch February 23, 2026 13:51
maximiliankolb added a commit to ATIX-AG/foreman-documentation that referenced this pull request Feb 23, 2026
@maximiliankolb
Communicate removal of ACD plugins
c63e029 
Refs theforeman#4420 (Announce ACD deprecation with 3.16)
@maximiliankolb maximiliankolb mentioned this pull request Feb 23, 2026
Merged
2 tasks
maximiliankolb added a commit to ATIX-AG/foreman-documentation that referenced this pull request Feb 24, 2026
@maximiliankolb
Communicate removal of ACD plugins
4cc7b03 
Refs theforeman#4420 (Announce ACD deprecation with 3.16)
maximiliankolb added a commit to ATIX-AG/foreman-documentation that referenced this pull request Feb 24, 2026
@maximiliankolb
Communicate removal of ACD plugins
c21071a 
Refs theforeman#4420 (Announce ACD deprecation with 3.16)
maximiliankolb added a commit that referenced this pull request Feb 24, 2026
@maximiliankolb
Communicate removal of ACD plugins (#4665)
1fff660 
Refs #4420 (Announce ACD deprecation with 3.16)
maximiliankolb added a commit to ATIX-AG/foreman-documentation that referenced this pull request Feb 24, 2026
@maximiliankolb
Revert "Add deprecation warning for ACD plugin (theforeman#4420)"
bac785b 
This reverts commit c2c42ca.

ACD plugins are still available for Foreman 3.17. They are gone for
Foreman 3.18.
maximiliankolb added a commit to ATIX-AG/foreman-documentation that referenced this pull request Feb 24, 2026
@maximiliankolb
Add deprecation warning for ACD plugin (theforeman#4420)
7a51d8c 
Foreman 3.17 does not support foreman_acd and smart_proxy_acd.

Refs theforeman#4359 (Remove docs for foreman_acd from nightly)

(cherry picked from commit c2c42ca)
maximiliankolb added a commit that referenced this pull request Feb 25, 2026
@maximiliankolb
Revert "Add deprecation warning for ACD plugin (#4420)" (#4670)
7fac6e9 
This reverts commit c2c42ca.

ACD plugins are still available for Foreman 3.17. They are gone for
Foreman 3.18.
maximiliankolb added a commit that referenced this pull request Feb 25, 2026
@maximiliankolb
Add deprecation warning for ACD plugin (#4420) (#4671)
0df236b 
Foreman 3.17 does not support foreman_acd and smart_proxy_acd.

Refs #4359 (Remove docs for foreman_acd from nightly)

(cherry picked from commit c2c42ca)
jafiala pushed a commit to jafiala/foreman-documentation that referenced this pull request Feb 26, 2026
@maximiliankolb @jafiala
Add deprecation warning for ACD plugin (theforeman#4420)
4904e7b 
Foreman 3.17 does not support foreman_acd and smart_proxy_acd.

Refs theforeman#4359 (Remove docs for foreman_acd from nightly)
jafiala pushed a commit to jafiala/foreman-documentation that referenced this pull request Feb 26, 2026
@maximiliankolb @jafiala
Revert "Add deprecation warning for ACD plugin (theforeman#4420)" (th…
6fa54e7 
…eforeman#4670)

This reverts commit c2c42ca.

ACD plugins are still available for Foreman 3.17. They are gone for
Foreman 3.18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aneta-petrova aneta-petrova aneta-petrova approved these changes

+1 more reviewer

@sbernhard sbernhard sbernhard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maximiliankolb @aneta-petrova @sbernhard