Skip to content

fix: light/dark toggle mode #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dendyjw
Copy link

@dendyjw dendyjw commented Apr 7, 2025

Fix icon display for moon on light mode, and the functionality toggle mode.

📑 Description

  • Fixed moon icon visibility in light mode by adjusting components properties
  • Fixed dark/light mode toggle functionality to ensure proper state synchronization

Status

  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Before Fix
The moon icon was not visible in light mode. The toggle sometimes failed to update the UI state.

After Fix

  • Moon icon now visible in light mode
  • Toggle works consistently

Screenshot Comparison

Light Mode Before Light Mode After
image image

Summary by CodeRabbit

  • New Features
    • Enhanced Dark Mode toggle now offers customizable icons for light and dark themes, delivering a more consistent and visually appealing appearance across modes.

Copy link

vercel bot commented Apr 7, 2025

@dendyjw is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Apr 7, 2025

Walkthrough

The changes update the dark mode toggle within the CTA component by modifying the DarkMode components. For light mode, the text-red-500 class was removed, and the component now uses Sun as a designated icon slot. For dark mode, a corresponding Moon icon is provided through a slot instead of conditional rendering. These adjustments streamline the component structure, ensure consistent sizing and padding, and simplify the appearance logic.

Changes

File Path Summary of Changes
src/routes/landing/CTA.svelte Updated DarkMode components: removed redundant styling (e.g., text-red-500), replaced conditionals with slot components (Sun for light mode and Moon for dark mode), and streamlined layout for uniform styling.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as CTA.svelte
    participant D as DarkMode
    participant S as Sun Icon
    participant M as Moon Icon

    U->>C: Load landing page
    C->>D: Render dark mode toggle
    alt Light Mode Active
      D->>S: Render Sun icon slot
      S-->>D: Sun icon displayed
    else Dark Mode Active
      D->>M: Render Moon icon slot
      M-->>D: Moon icon displayed
    end
    D-->>C: Toggle update
    C-->>U: Display updated toggle visuals
Loading

Poem

I'm a little rabbit, hopping through the code,
With Sun and Moon by my side on our dark mode road.
Simplified slots and cleaner styles set the stage,
For a brighter, cozier look on every digital page.
Hoppy cheers for changes — coding is our joyful ode!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

 WARN  Ignoring not compatible lockfile at /tmp/eslint/pnpm-lock.yaml
 WARN  GET http://10.0.0.28:4873/globals error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/svelte error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-config-prettier error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/@types%2Feslint error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/typescript error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/typescript-eslint error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-plugin-svelte error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/prettier error (503). Will retry in 10 seconds. 2 retries left.
 WARN  GET http://10.0.0.28:4873/globals error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/svelte error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/@types%2Feslint error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/eslint error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-config-prettier error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/typescript error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/prettier error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/typescript-eslint error (503). Will retry in 1 minute. 1 retries left.
 WARN  GET http://10.0.0.28:4873/eslint-plugin-svelte error (503). Will retry in 1 minute. 1 retries left.
 ERR_PNPM_FETCH_503  GET http://10.0.0.28:4873/globals: Service Unavailable - 503

This error happened while installing a direct dependency of /tmp/eslint


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21c5c2f and 88cc3c8.

📒 Files selected for processing (1)
  • src/routes/landing/CTA.svelte (1 hunks)
🔇 Additional comments (3)
src/routes/landing/CTA.svelte (3)

48-64: Improved dark/light mode toggle implementation with consistent icon display

The changes properly address the moon icon visibility issue in light mode by using explicit slots for both light and dark mode icons. The implementation now ensures consistent display of icons regardless of the current theme.


50-53: Light mode toggle now properly configured

The light mode toggle has been improved by:

  1. Removing the unnecessary text-red-500 class
  2. Adding explicit sizing with w-11 h-11 p-2
  3. Using the Sun component in explicit icon slots

58-61: Dark mode toggle now correctly displays Moon icon

The dark mode toggle has been improved by:

  1. Adding consistent sizing that matches the light mode toggle
  2. Adding a hover effect for better user interaction
  3. Using the Moon component in explicit icon slots, fixing the visibility issue

The implementation now ensures the Moon icon is visible in both light and dark modes as intended.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Fix icon display for moon on light mode, and the functionality toggle mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant