events.next() is placed in the wrong scope #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you leave out the query parameter the events.next() function will not receive the parameter cleanup as it is placed in the wrong scope.
adrai
added a commit
that referenced
this pull request
Nov 14, 2017
|
Sorry I didn't want to make this confusion... (this happens when trying to use GitHub features on my mobile...) Just wanted to ask if there is not again a memory issue when always defining the nextFn function on each page? |
|
should be fixed in v1.12.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug fix to issue #112 left the events.next() function in the wrong scope. So if you call es.getEvents((err, events) => {...}) without query and/or skip, limit parameters the events.next() won't receive the parameter cleanup and behave in an unpredictable way.