Fix concurrency issue in createTableIfNotExists (DynamoDB adapter) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During concurrent operations there is no guarantee that a table is not created between checking it's existance (using describeTable) and making the call to create the table. Currently, when this happens, it is erroring out with the 'Cannot create preexisting table' error. Even ensuring that the init promise is resolved before calling it again is not enough because the call to describeTable is eventually consistent. The fix is to swallow the error when the table already exists. At the end of the day, the system is in the state that we want it to be anyway (the table exists).
DannyRyman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During concurrent operations there is no guarantee that a table is not created between checking it's existance (using describeTable) and making the call to create the table. Currently, when this happens, it is erroring out with the 'Cannot create preexisting table' error.
Even ensuring that the init promise is resolved before calling it again is not enough because the call to describeTable is eventually consistent.
The fix is to swallow the error when the table already exists. At the end of the day, the system is in the state that we want it to be anyway (the table exists).