Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate identifiers for event documents rather than deriving them #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Generate identifiers for event documents rather than deriving them #139

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8846a1
generate new event id rather than deriving it
Feb 19, 2019
30c615a
update mongo methods to non-deprecated versions
Feb 19, 2019
1cc70a7
merge from adrai
Feb 20, 2019
80d88a1
generate ids in waterfall to support async
Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 58 additions & 50 deletions lib/eventstore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,64 +474,72 @@ _.extend(Eventstore.prototype, {
commit: function(eventstream, callback) {

var self = this;
var waterfallFuncs = [];
var idSet = [];

waterfallFuncs.push(function getNewId(callback) {
self.getNewId(callback);
});

async.waterfall([

function getNewCommitId(callback) {
// Generate an id for each uncommitted event
for (var i= 0, len = eventstream.uncommittedEvents.length; i < len; i++) {
waterfallFuncs.push(function getAnotherId(previousId, callback) {
idSet.push(previousId);
self.getNewId(callback);
},
});
}
waterfallFuncs.push(function commitEvents(id, callback) {
idSet.push(id);

// start committing.
var event,
currentRevision = eventstream.currentRevision(),
uncommittedEvents = [].concat(eventstream.uncommittedEvents);
eventstream.uncommittedEvents = [];

self.store.getNextPositions(uncommittedEvents.length, function(err, positions) {
if (err)
return callback(err)

for (var i = 0, len = uncommittedEvents.length; i < len; i++) {
event = uncommittedEvents[i];
event.id = idSet[i+1]; // additional ids generated by getAnotherId function
event.commitId = idSet[0]; // first id generated is for the commit
event.commitSequence = i;
event.restInCommitStream = len - 1 - i;
event.commitStamp = new Date();
currentRevision++;
event.streamRevision = currentRevision;
if (positions)
event.position = positions[i];

event.applyMappings();
}

function commitEvents(id, callback) {
// start committing.
var event,
currentRevision = eventstream.currentRevision(),
uncommittedEvents = [].concat(eventstream.uncommittedEvents);
eventstream.uncommittedEvents = [];

self.store.getNextPositions(uncommittedEvents.length, function(err, positions) {
if (err)
return callback(err)

for (var i = 0, len = uncommittedEvents.length; i < len; i++) {
event = uncommittedEvents[i];
event.id = id + i.toString();
event.commitId = id;
event.commitSequence = i;
event.restInCommitStream = len - 1 - i;
event.commitStamp = new Date();
currentRevision++;
event.streamRevision = currentRevision;
if (positions)
event.position = positions[i];

event.applyMappings();
self.store.addEvents(uncommittedEvents, function(err) {
if (err) {
// add uncommitted events back to eventstream
eventstream.uncommittedEvents = uncommittedEvents.concat(eventstream.uncommittedEvents);
return callback(err);
}

self.store.addEvents(uncommittedEvents, function(err) {
if (err) {
// add uncommitted events back to eventstream
eventstream.uncommittedEvents = uncommittedEvents.concat(eventstream.uncommittedEvents);
return callback(err);
}

if (self.publisher && self.dispatcher) {
// push to undispatchedQueue
self.dispatcher.addUndispatchedEvents(uncommittedEvents);
} else {
eventstream.eventsToDispatch = [].concat(uncommittedEvents);
}
if (self.publisher && self.dispatcher) {
// push to undispatchedQueue
self.dispatcher.addUndispatchedEvents(uncommittedEvents);
} else {
eventstream.eventsToDispatch = [].concat(uncommittedEvents);
}

// move uncommitted events to events
eventstream.events = eventstream.events.concat(uncommittedEvents);
eventstream.currentRevision();
// move uncommitted events to events
eventstream.events = eventstream.events.concat(uncommittedEvents);
eventstream.currentRevision();

callback(null, eventstream);
});
callback(null, eventstream);
});
}],

callback
);
});
});

async.waterfall(waterfallFuncs, callback);
},

/**
Expand Down