Skip to content

Conversation

@marco-2023
Copy link
Contributor

Checklist

  • Write a good description of what the PR does.
  • Add tests for each unit of code added (e.g. function, class)
  • Update documentation
  • Squash commits that can be grouped together
  • Rebase onto master

Type of Changes

Type
✨ New feature

Related

@marco-2023 marco-2023 requested a review from Copilot October 25, 2025 17:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds screening functionality to the stress tensor module by introducing screen_basis and tol_screen parameters to three key functions: evaluate_stress_tensor, evaluate_ehrenfest_force, and evaluate_ehrenfest_hessian. The default value for screen_basis has been changed from True to False across multiple modules to maintain consistency.

Key Changes

  • Added screen_basis and tol_screen parameters to stress tensor evaluation functions
  • Updated default value of screen_basis from True to False across integral and evaluation modules
  • Enhanced test coverage to validate screening functionality with both enabled and disabled screening

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
gbasis/evals/stress_tensor.py Added screening parameters to stress tensor, Ehrenfest force, and Ehrenfest Hessian functions
tests/test_stress_tensor.py Parametrized tests to validate both screened and non-screened evaluations
gbasis/integrals/overlap.py Changed default screen_basis from True to False
gbasis/integrals/overlap_asymm.py Changed default screen_basis from True to False
gbasis/integrals/momentum.py Changed default screen_basis from True to False
gbasis/integrals/moment.py Changed default screen_basis from True to False
gbasis/integrals/kinetic_energy.py Changed default screen_basis from True to False
gbasis/integrals/angular_momentum.py Changed default screen_basis from True to False
gbasis/evals/eval_deriv.py Changed default screen_basis from True to False and updated documentation
gbasis/evals/eval.py Changed default screen_basis from True to False and updated documentation
gbasis/evals/density.py Changed default screen_basis from True to False across multiple functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

screen_basis : bool, optional
Whether to screen out points that are too far from the contraction center. Default value
is True (enable screening).
False.
Copy link

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated documentation on line 85 is incomplete and grammatically incorrect. It should read 'Default value is False.' to match the documentation pattern used elsewhere in the codebase.

Copilot uses AI. Check for mistakes.
@marco-2023 marco-2023 requested a review from PaulWAyers October 25, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant