Skip to content

Conversation

@marco-2023
Copy link
Contributor

Checklist

  • Write a good description of what the PR does.
  • Add tests for each unit of code added (e.g. function, class)
  • Update documentation
  • Rebase onto master

Type of Changes

Type
✨ New feature

Related

@marco-2023 marco-2023 requested a review from Copilot October 26, 2025 08:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds screening support to point charge integrals and related stress tensor quantities. The changes enable optional basis function screening for performance optimization while maintaining numerical accuracy.

Key changes:

  • Added screen_basis and tol_screen parameters to point charge integral functions
  • Updated stress tensor evaluation functions to support screening
  • Changed default screen_basis value from True to False across multiple integral types for consistency
  • Enhanced tests to verify screened and non-screened calculations match within tolerance

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gbasis/integrals/point_charge.py Implemented screening logic for point charge integrals with point masking
gbasis/integrals/nuclear_electron_attraction.py Added screening parameters to nuclear-electron attraction integrals
gbasis/evals/stress_tensor.py Added screening support to stress tensor, Ehrenfest force, and Hessian functions
gbasis/integrals/overlap.py Changed default screen_basis from True to False
gbasis/integrals/overlap_asymm.py Changed default screen_basis from True to False
gbasis/integrals/kinetic_energy.py Changed default screen_basis from True to False
gbasis/integrals/momentum.py Changed default screen_basis from True to False
gbasis/integrals/moment.py Changed default screen_basis from True to False
gbasis/integrals/angular_momentum.py Changed default screen_basis from True to False
gbasis/evals/eval.py Changed default screen_basis from True to False and updated docstrings
gbasis/evals/eval_deriv.py Changed default screen_basis from True to False and updated docstrings
gbasis/evals/density.py Changed default screen_basis from True to False across multiple functions
gbasis/evals/electrostatic_potential.py Added comment explaining no screening for cumulative point charges
tests/test_point_charge.py Added parametrized tests for screening with tolerance checks
tests/test_nuclear_electron_attraction.py Added parametrized tests for screening scenarios
tests/test_stress_tensor.py Enhanced tests with screening parameters and non-screened reference calculations
tests/test_density.py Simplified parametrization to use tuples instead of separate parameters
tests/test_angular_momentum.py Added screening tests and adjusted tolerance for screening accuracy test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marco-2023 marco-2023 requested a review from PaulWAyers October 26, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant