Skip to content

Challenge 1 & 2 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

nikhil2798
Copy link

Extraction of the frequency from the log file and converting the frequency in the order of GHz.

PS: I am extremely sorry to upload the wrong file (challenge_1_2.pl) by mistake.
The final file is challenge12_final.

Extracting the maximum clock speed from a Timing Report and expressing in terms of GHz.
@thesourcerer8
Copy link
Owner

Please always close filehandles directly after you have used them.

@thesourcerer8
Copy link
Owner

Now I tested it, and it errorneously says "Computed maximum clock frequency isn't avaiable in the report." many times.

@shivanishah269
Copy link

As you have written this statement in while loop (Computed maximum clock frequency isn't avaiable in the report.), the statement is getting printed many times because only 1 line will match rest won't. So, I would suggest better write that line outside the while loop.

One more suggestion, take filename as input from the user itself.

@nikhil2798
Copy link
Author

@shivanishah269 I cross checked the while loop error but it is fine when I am running the code without "Computed maximum clock frequency".

Yeah it makes more sense if the user can enter the filename. I have made this change in the code.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants