Skip to content

fix(react-ui): don't auto-select the last tab on Tabs initial mount #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shinyaigeek wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix(react-ui): don't auto-select the last tab on Tabs initial mount #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-ui/src/genui-lib/Tabs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ export const Tabs = defineComponent({
React.useEffect(() => {
if (userHasInteracted.current) return;

// On the first pass every tab satisfies `size > 0`, which would make
// `candidate` end up as the LAST tab and override the first-tab default
// above. Only record the baseline sizes; growth relative to this
// baseline (or a tab appearing later) still auto-advances.
const isBaselinePass = Object.keys(prevContentSizes.current).length === 0;

let candidate: string | null = null;
const nextSizes: Record<string, number> = {};

Expand All @@ -56,6 +62,8 @@ export const Tabs = defineComponent({

prevContentSizes.current = nextSizes;

if (isBaselinePass) return;

if (candidate && candidate !== activeTab) {
setActiveTab(candidate);
}
Expand Down
Loading