Skip to content

tests: Increase restart tedge-agent test timeout #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Mar 4, 2025

Proposed changes

Even though the tedge-agent would complete a shutdown within a matter milliseconds in most cases, sometimes all actors may not shutdown immediately as seen in #3415 extending the time taken for the shutdown. The actor runtime will wait upto 60 seconds for all actors to gracefully shutdown. So, adjusting the test workflow also accordingly.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3415

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
583 0 3 583 100 1h35m56.935904999s

@reubenmiller reubenmiller added the theme:testing Theme: Testing label Mar 4, 2025
@albinsuresh albinsuresh added this pull request to the merge queue Mar 5, 2025
Merged via the queue into thin-edge:main with commit d487595 Mar 5, 2025
31 checks passed
@albinsuresh albinsuresh deleted the fix/restart-agent-test branch March 6, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing Theme: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants