Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to improve some codes in QuadForm #1254

Merged
merged 5 commits into from
Oct 27, 2023
+563 −590
Merged

Attempt to improve some codes in QuadForm #1254

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b4a071
hopefully some improvements
StevellM Oct 20, 2023
286e078
missing bit
StevellM Oct 20, 2023
efd98dd
fix docs
StevellM Oct 20, 2023
aeef2ff
apply suggestions: revert some changes, add more init
StevellM Oct 23, 2023
5973970
apply further suggestions
StevellM Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing bit
@StevellM
StevellM committed Oct 20, 2023
commit 286e0787730367840dc82a27cceddb9abdc36dc3
2 changes: 1 addition & 1 deletion src/QuadForm/Torsion.jl
View file
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ function torsion_quadratic_module(M::ZZLat, N::ZZLat; gens::Union{Nothing, Vecto

num = basis_matrix(M) * gram_matrix(ambient_space(M)) * transpose(basis_matrix(N))
if iszero(modulus)
modulus = reduce(gcd, [a for a in num]; init = zero(QQFieldElem))
modulus = reduce(gcd, num; init = zero(QQFieldElem))
end
norm = reduce(gcd, diagonal(gram_matrix(N)); init = zero(QQFieldElem))