🤖 Update Mock Benchmark Results#5970
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Code Review
This is an automated benchmark data refresh — the workflow machinery is solid and the changes are what you'd expect from a scheduled CI run. A few observations:
Schema Evolution in MockCreation.json
The most notable change here isn't the numbers — it's that ** now includes a new "Median" field** for every entry, while the other five benchmark JSON files (, , , , ) do not get this field in this run.
This creates a schema inconsistency across the benchmark data files. Two things to consider:
- Documentation lag: The markdown table still only renders — the new
Medianvalue is captured in the JSON but never surfaced to readers. - Partial rollout: If the benchmark runner now produces
Medianfor all categories, the other JSON files should have received it too. If it's category-specific, it'd be worth a comment in the generation script explaining why.
Suggested approach: Either update the markdown template to include a Median column (making the data useful), or strip Median from the JSON until all categories produce it and the docs are ready to display it. Inconsistent schemas across sibling files make the data harder to consume programmatically.
Benchmark Numbers
The numeric changes are within normal day-to-day variance — no surprising regressions or improvements. A few observations for context:
- TUnit.Mocks Callback went from 595ns → 649ns (~9% slower), but the error bands overlap so this is noise.
- CombinedWorkflow shows Moq improving significantly (408μs → 309μs) — this is a large swing for a single day; worth keeping an eye on in subsequent runs to see if it stabilises or reverts.
- Memory allocations are stable across the board, which is the more meaningful signal.
Automation Quality
The PR description correctly tracks the workflow run ID, trigger type, and lists all artifact categories. The commit message is clean. The automation is working as intended.
Overall: good automated update. The schema inconsistency with Median is the only thing worth addressing before this pattern solidifies.
There was a problem hiding this comment.
Code Review
This is an automated benchmark data refresh — the workflow machinery is solid and the changes are what you'd expect from a scheduled CI run. A few observations:
Schema Evolution in MockCreation.json
The most notable change here isn't the numbers — it's that MockCreation.json now includes a new "Median" field for every entry, while the other five benchmark JSON files (Callback, Invocation, CombinedWorkflow, Setup, Verification) do not get this field in this run.
This creates a schema inconsistency across the benchmark data files. Two things to consider:
- Documentation lag: The
MockCreation.mdmarkdown table still only rendersMean | Error | StdDev | Allocated— the newMedianvalue is captured in the JSON but never surfaced to readers. - Partial rollout: If the benchmark runner now produces
Medianfor all categories, the other JSON files should have received it too. If it's category-specific, it'd be worth a comment in the generation script explaining why.
Suggested approach: Either update the markdown template to include a Median column (making the data useful), or strip Median from the JSON until all categories produce it and the docs are ready to display it. Inconsistent schemas across sibling files make the data harder to consume programmatically.
Benchmark Numbers
The numeric changes are within normal day-to-day variance — no surprising regressions. A few observations for context:
- TUnit.Mocks Callback went from 595ns → 649ns (~9% slower), but the error bands overlap so this is noise.
- CombinedWorkflow shows Moq improving significantly (408μs → 309μs) — this is a large swing for a single day; worth watching in subsequent runs to see if it stabilises or reverts.
- Memory allocations are stable across the board, which is the more meaningful signal.
Automation Quality
The PR description correctly tracks the workflow run ID, trigger type, and lists all artifact categories. The commit message is clean. The automation is working as intended.
Overall: good automated update. The schema inconsistency with Median is the only thing worth addressing before this pattern solidifies.
Automated Mock Benchmark Update
This PR updates the mock benchmark documentation with the latest results from the Mock Benchmarks workflow.
Benchmarks Produced
Individual benchmark artifacts are available for download:
mock-benchmark-MockCreationmock-benchmark-Setupmock-benchmark-Invocationmock-benchmark-Verificationmock-benchmark-Callbackmock-benchmark-CombinedWorkflowmock-benchmark-summary(aggregated overview)Libraries Compared
Libraries are discovered dynamically from the benchmark output. See the generated
summary.jsonfor the full list.Changes
docs/static/benchmarks/mocks/latest.jsondocs/docs/benchmarks/mocks/docs/static/benchmarks/mocks/summary.jsonWorkflow Run
🤖 This PR was automatically created and will be merged automatically once CI checks pass.